Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ruby code block - bucket sort #1285

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Conversation

martinx
Copy link
Contributor

@martinx martinx commented Apr 17, 2024

If this pull request (PR) pertains to Chinese-to-English translation, please confirm that you have read the contribution guidelines and complete the checklist below:

  • This PR represents the translation of a single, complete document, or contains only bug fixes.
  • The translation accurately conveys the original meaning and intent of the Chinese version. If deviations exist, I have provided explanatory comments to clarify the reasons.

If this pull request (PR) is associated with coding or code transpilation, please attach the relevant console outputs to the PR and complete the following checklist:

  • I have thoroughly reviewed the code, focusing on its formatting, comments, indentation, and file headers.
  • I have confirmed that the code execution outputs are consistent with those produced by the reference code (Python or Java).
  • The code is designed to be compatible on standard operating systems, including Windows, macOS, and Ubuntu.

Copy link
Contributor

@khoaxuantu khoaxuantu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @martinx, I just have some comments below.

codes/ruby/chapter_sorting/bucket_sort.rb Outdated Show resolved Hide resolved
codes/ruby/chapter_sorting/bucket_sort.rb Show resolved Hide resolved
martinx and others added 2 commits April 19, 2024 08:28
Co-authored-by: khoaxuantu <68913255+khoaxuantu@users.noreply.github.com>
Co-authored-by: khoaxuantu <68913255+khoaxuantu@users.noreply.github.com>
@martinx
Copy link
Contributor Author

martinx commented Apr 19, 2024

@khoaxuantu Thanks for your suggestions.

Copy link
Owner

@krahets krahets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

codes/ruby/chapter_sorting/bucket_sort.rb Outdated Show resolved Hide resolved
@krahets krahets added the code Code-related label Apr 30, 2024
@krahets krahets merged commit 59d0726 into krahets:main Apr 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Code-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants