feat: Add ruby codes - chapter "Heap" #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 tasks
khoaxuantu
reviewed
Apr 23, 2024
khoaxuantu
reviewed
Apr 26, 2024
codes/ruby/chapter_heap/my_heap.rb
Outdated
| # 将列表元素原封不动添加进堆 | ||
| @max_heap = nums.to_a | ||
| # 堆化除叶节点以外的其他所有节点 | ||
| for i in (0...parent(size)).reverse_each |
There was a problem hiding this comment.
This traverses in range (parent(size), 0]. It is different from the reference codes, which traverse in range [parent(size - 1), 0].
I would not recommend to use reverse_each here due to the readability (you have to imagine a reverse range when looking at it). Instead, we can use
parent(size - 1).downto(0)
codes/ruby/chapter_heap/my_heap.rb
Outdated
| end | ||
|
|
||
| ### 获取堆的数组形式 ### | ||
| def to_a |
There was a problem hiding this comment.
Please use a getter attr_reader for this method and put it on top of the class. Make sure you change the method references.
### 获取堆的数组形式 ###
attr_reader :max_heapThere was a problem hiding this comment.
Thanks for review! I have fix them in aa99844
Co-authored-by: khoaxuantu <68913255+khoaxuantu@users.noreply.github.com>
Co-authored-by: khoaxuantu <68913255+khoaxuantu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because there is no heap or priority queue in the Ruby standard library, "heap.rb" should not exist, and I used "my_heap.rb" to finish "top_k.rb", refering to the C version.
If this pull request (PR) is associated with coding or code transpilation, please attach the relevant console outputs to the PR and complete the following checklist: