Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: modify some Dart codes and fill in the empty Dart code blocks in docs #543

Merged
merged 1 commit into from
Jun 2, 2023
Merged

feat: modify some Dart codes and fill in the empty Dart code blocks in docs #543

merged 1 commit into from
Jun 2, 2023

Conversation

gvenusleo
Copy link
Contributor

If this PR is related to coding or code translation, please fill out the checklist and paste the console outputs to the PR.

  • I've tested the code and ensured the outputs are the same as the outputs of reference codes.
  • I've checked the codes (formatting, comments, indentation, file header, etc) carefully.
  • The code does not rely on a particular environment or IDE and can be executed on a standard system (Win, macOS, Ubuntu).

@vercel
Copy link

vercel bot commented Jun 2, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
hello-algo ⬜️ Ignored (Inspect) Jun 2, 2023 6:45am

@gvenusleo gvenusleo mentioned this pull request Jun 2, 2023
Open
krahets
krahets approved these changes Jun 2, 2023
View reviewed changes
Copy link
Owner

@krahets krahets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the PR!

krahets
krahets approved these changes Jun 2, 2023
View reviewed changes
Copy link
Owner

@krahets krahets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the PR!

@krahets krahets merged commit 281c0c6 into krahets:main Jun 2, 2023
1 check passed
@krahets krahets added the code Code-related label Jun 2, 2023
@krahets
Copy link
Owner

krahets commented Jun 2, 2023

Would you like to be the reviewer of Dart code for this book?

  • All the PRs related to Dart will be assigned to you for review.
  • Your GitHub id will be listed in the preface section of the book together with other reviewers.

And if you want to trace the latest updates of the book, please add my WeChat krahets-jyd.

@gvenusleo
Copy link
Contributor Author

I would love to be the reviewer of Dart code! I've applied to add your WeChat.

Also, I just submitted a PR to modify the two_sum.dart .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krahets krahets krahets approved these changes

Assignees
No one assigned
Labels
code Code-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gvenusleo @krahets