Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translation: chapter_introduction/what_is_dsa.md #962

Merged
merged 2 commits into from
Dec 11, 2023
Merged

translation: chapter_introduction/what_is_dsa.md #962

merged 2 commits into from
Dec 11, 2023

Conversation

krahets
Copy link
Owner

@krahets krahets commented Nov 21, 2023

If this PR is related to coding or code translation, please fill out the checklist and paste the console outputs to the PR.

  • I've tested the code and ensured the outputs are the same as the outputs of reference code.
  • I've checked the code (formatting, comments, indentation, file header, etc) carefully.
  • The code does not rely on a particular environment or IDE and can be executed on a standard system (Win, macOS, Ubuntu).

@krahets krahets added translation English translation documents documents-related labels Nov 21, 2023
@krahets krahets self-assigned this Nov 21, 2023
Phoenix0415
Phoenix0415 reviewed Dec 11, 2023
View reviewed changes
Copy link
Contributor

@Phoenix0415 Phoenix0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

整体很好，我在一些地方提了微调的建议

docs-en/chapter_introduction/what_is_dsa.md Outdated Show resolved Hide resolved
docs-en/chapter_introduction/what_is_dsa.md Outdated
- Problems are well defined and contain clear definitions of inputs and outputs.
- Feasible and able to be accomplished with limited steps, time and memory space.
- Each step has a defined meaning and the output is always the same for the same inputs and operating conditions.
- The problem is clearly defined, including clear definitions of input and output.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear Problem Definition: It includes precise definitions of inputs and outputs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracting keywords to make the topic more outstanding

Copy link
Owner Author

@krahets krahets Dec 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

语句结构变化，需要先提交中文 PR 。

我认为一句话已经足够精炼，不太需要再进行关键词提炼。例如，在中文原文中：

  • 问题是明确的，包含清晰的输入和输出定义。
  • 清晰的问题定义：它包含清晰的输入和输出。

下面这种提炼 keywords 的格式比较“GPT”。看上去关键词被提炼出来了，实际上增益并不大，反而可能导致一句话的结构被破坏掉。
如果我们想对这个定义进行更为全面的描述。那么提炼关键词的增益才会比较大。

docs-en/chapter_introduction/what_is_dsa.md Outdated Show resolved Hide resolved
docs-en/chapter_introduction/what_is_dsa.md Outdated Show resolved Hide resolved
docs-en/chapter_introduction/what_is_dsa.md
- Space occupation is minimized to save computer memory.
- Data manipulation is as fast as possible, covering data access, additions, deletions, updates, etc.
- Provide concise data representation and logical information in order to make the algorithm work efficiently.
- Minimize space occupancy to save computer memory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以考虑
Minimal Space Usage: To conserve computer memory.

Copy link
Owner Author

@krahets krahets Dec 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

语句结构变化，需要先提交中文 PR 。

这句话也是类似问题，由于很短，因此重点提炼的增益比较小。

docs-en/chapter_introduction/what_is_dsa.md Outdated Show resolved Hide resolved
docs-en/chapter_introduction/what_is_dsa.md Outdated Show resolved Hide resolved
docs-en/chapter_introduction/what_is_dsa.md Outdated Show resolved Hide resolved
docs-en/chapter_introduction/what_is_dsa.md Outdated Show resolved Hide resolved
docs-en/chapter_introduction/what_is_dsa.md Outdated Show resolved Hide resolved
@krahets
Copy link
Owner Author

krahets commented Dec 11, 2023

Thanks for your review @Phoenix0415 @yanedie ! All the comments have been addressed. Please check them.

@krahets krahets merged commit c5f5abf into en Dec 11, 2023
1 check passed
@krahets krahets deleted the en-dev branch December 11, 2023 12:38
krahets added a commit that referenced this pull request Dec 21, 2023
@krahets @yuelinxin
@Phoenix0415 @longsizhuo @QiLOL @thomasq0 @K3v123 @yanedie
translation: English Translation of the chapter of preface(part), int…
46813a5 
…roduction and complexity analysis(part) (#994)

* Translate 1.0.0b6 release with the machine learning translator.

* Update Dockerfile
A few translation improvements.

* Fix a badge logo.

* Fix EN translation of chapter_appendix/terminology.md (#913)

* Update README.md

* Update README.md

* translation: Refined the automated translation of README (#932)

* refined the automated translation of README

* Update index.md

* Update mkdocs-en.yml

---------

Co-authored-by: Yudong Jin <krahets@163.com>

* translate: Embellish chapter_computational_complexity/index.md (#940)

* translation: Update chapter_computational_complexity/performance_evaluation.md (#943)

* Update performance_evaluation.md

* Update performance_evaluation.md

* Update performance_evaluation.md

change 'methods' to 'approaches' on line 15

* Update performance_evaluation.md

on line 21, change the sentence to 'the results could be the opposite on another computer with different specifications.'

* Update performance_evaluation.md

delete two short sentence on line 5 and 6

* Update performance_evaluation.md

change `unavoidable` to `inevitable` on line 48

* Update performance_evaluation.md

small changes on line 23

* translation: Update terminology and improve readability in preface summary (#954)

* Update terminology and improve readability in preface summary

This commit made a few adjustments in the 'summary.md' file for clearer and more accessible language. "Brushing tool library" was replaced with "Coding Toolkit" to better reflect common terminology. Also, advice for beginners in algorithm learning journey was reformulated to imply a more positive approach avoiding detours and common pitfalls. The section related to the discussion forum was rewritten to sound more inviting to readers.

* Format

* Optimize the translation of
chapter_introduction/algorithms_are_everywhere.

* Add .gitignore to Java subfolder.

* Update the button assets.

* Fix the callout

* translation: chapter_computational_complexity/summary to en (#953)

* translate chapter_computational_complexity/summary

* minor format

* Update summary.md with comment

* Update summary.md

* Update summary.md

* translation: chapter_introduction/what_is_dsa.md (#962)

* Optimize translation of what_is_dsa.md

* Update

* translation: chapter_introduction/summary.md (#963)

* Translate chapter_introduction/summary.md

* Update

* translation: Update README.md (#964)

* Update en translation of README.md

* Update README.md

* translation: update space_complexity.md (#970)

* update space_complexity.md

* the rest of translation piece

* Update space_complexity.md

---------

Co-authored-by: ThomasQiu <thomas.qiu@mnfgroup.limited>
Co-authored-by: Yudong Jin <krahets@163.com>

* translation: Update chapter_introduction/index.md (#971)

* Update index.md

sorry, first time doing this... now this is the final change.
changes:
title of the chapter is shorter.
refined the abstract.

* Update index.md

---------

Co-authored-by: Yudong Jin <krahets@163.com>

* translation: Update chapter_data_structure/classification_of_data_structure.md (#980)

* update classification_of_data_structure.md

* Update classification_of_data_structure.md

---------

Co-authored-by: Yudong Jin <krahets@163.com>

* translation: Update chapter_introduction/algorithms_are_everywhere.md (#972)

* Update algorithms_are_everywhere.md

changed or refined parts of the words and sentences including tips.
Some of them I didnt change that much because im worried that it might not meet the requirement of accuracy. 
some other ones i changed a lot to make it sound better, but also kind of following the same wording as the CN version

* Update algorithms_are_everywhere.md

re-edited the dictionary part from Piyin to just normal Eng dictionary. 
again thank you very much hpstory for you suggestion.

* Update algorithms_are_everywhere.md

---------

Co-authored-by: Yudong Jin <krahets@163.com>

* Prepare merging into main branch.

* Update buttons

* Update Dockerfile

* Update index.md

* Update index.md

* Update README

* Fix index.md

* Fix mkdocs-en.yml

---------

Co-authored-by: Yuelin Xin <sc20yx2@leeds.ac.uk>
Co-authored-by: Phoenix Xie <phoenixx0415@gmail.com>
Co-authored-by: Sizhuo Long <longsizhuo@gmail.com>
Co-authored-by: Spark <qizhang94@outlook.com>
Co-authored-by: Thomas <thomasqiu7@gmail.com>
Co-authored-by: ThomasQiu <thomas.qiu@mnfgroup.limited>
Co-authored-by: K3v123 <123932560+K3v123@users.noreply.github.com>
Co-authored-by: Jin <36914748+yanedie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanedie yanedie yanedie approved these changes

@Phoenix0415 Phoenix0415 Phoenix0415 approved these changes

Assignees

@krahets krahets

Labels
documents documents-related translation English translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@krahets @yanedie @Phoenix0415