Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

callback shortcut #959

Closed
wants to merge 2 commits into from
Closed

callback shortcut #959

wants to merge 2 commits into from

Conversation

mche
Copy link

@mche mche commented May 12, 2016

Hi!

mche added 2 commits May 12, 2016 09:30
$r->to(sub{...})
@marcusramberg
Copy link
Member

marcusramberg commented May 12, 2016

This pull request needs an actual description and tests to be considered.

@mche
Copy link
Author

mche commented May 12, 2016

an actual description

$r->to(sub {...})

is same as

$r->to(cb=>sub {...})

tests

Ok

@mche
Copy link
Author

mche commented May 12, 2016

huge amount tests in /t!
suggest me where to place test callback action.

@jberger
Copy link
Member

jberger commented May 12, 2016

Why wouldn't you just use the hybrid route approach at this point? $r->any('/path' => sub { ... })

@kraih
Copy link
Member

kraih commented May 12, 2016

👎 from me, since we already have enough alternatives and the pull request is missing a lot.

@jberger
Copy link
Member

jberger commented May 12, 2016

without a compelling reason not to use the hybrid routes I mentioned, I think I'm a 👎 as well, for the same reason as @kraih

@mche
Copy link
Author

mche commented May 13, 2016

Okay, not so important/significant

@jberger jberger closed this May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants