Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilise False value in the OsmTagsFilter #49

Closed
RaczeQ opened this issue Feb 15, 2024 · 0 comments · Fixed by #66
Closed

Utilise False value in the OsmTagsFilter #49

RaczeQ opened this issue Feb 15, 2024 · 0 comments · Fixed by #66
Labels
enhancement New feature or request QoL Quality of Life

Comments

@RaczeQ
Copy link
Collaborator

RaczeQ commented Feb 15, 2024

Currently only True value is used in filtering.
It should be possible to filter features based on missing tags where user passed False as a filter value.
For now, all of the filters are connected with the OR operator logic-wise. Adding negative filters should be joined with an AND operator.

Example logic:

osm_filter = {"amenity": True, "building": True, "office": False, "leisure": False}

condition = (("amenity" in tags) or ("building" in tags)) and (("office" not in tags) and ("leisure" not in tags))
@RaczeQ RaczeQ added enhancement New feature or request QoL Quality of Life labels Feb 15, 2024
@RaczeQ RaczeQ linked a pull request Mar 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request QoL Quality of Life
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant