Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilise wildcard on keys in the OsmTagsFilter #53

Closed
StephanGeorg opened this issue Mar 7, 2024 · 2 comments · Fixed by #66
Closed

Utilise wildcard on keys in the OsmTagsFilter #53

StephanGeorg opened this issue Mar 7, 2024 · 2 comments · Fixed by #66

Comments

@StephanGeorg
Copy link

StephanGeorg commented Mar 7, 2024

Feature request

In OSM it is very common to use keys like name:en, name:street:en, addr:postcode, ref:source:

In cases where it is necessary to filter all combinations (e.g. all translations of a name: attribute), all available keys must be specified in osm-tags-filter-file instead of just using "name:*": true, for example.

@StephanGeorg
Copy link
Author

I would ❤️ to work on improving filtering (also on #49). Unfortunately I am not a Python developer. But if you could give me some hints, I could try to contribute.

@RaczeQ
Copy link
Collaborator

RaczeQ commented Apr 17, 2024

Hi @StephanGeorg, I've finally had time to plan and finish this feature (together with False values inside filters).
I've also prepared extensive documentation for this feature which is available here: https://kraina-ai.github.io/quackosm/0.6.0/examples/advanced_examples/osm_tags_filter/#positive-and-negative-filters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants