Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change keep_all_tags logic with grouped osm tags filters #39

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

RaczeQ
Copy link
Collaborator

@RaczeQ RaczeQ commented Feb 2, 2024

No description provided.

@RaczeQ RaczeQ changed the title fix: change grouped osm tags filter logic with keep_all_tags parameter fix: change keep_all_tags logic with grouped osm tags filters Feb 2, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5013049) 85.73% compared to head (ed86143) 85.73%.

Files Patch % Lines
quackosm/_osm_tags_filters.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #39   +/-   ##
=======================================
  Coverage   85.73%   85.73%           
=======================================
  Files          18       18           
  Lines        1360     1360           
=======================================
  Hits         1166     1166           
  Misses        194      194           
Flag Coverage Δ
macos-latest-python3.11 85.51% <66.66%> (ø)
ubuntu-latest-python3.10 85.51% <66.66%> (ø)
ubuntu-latest-python3.11 85.51% <66.66%> (ø)
ubuntu-latest-python3.9 85.51% <66.66%> (ø)
windows-latest-python3.11 85.73% <66.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RaczeQ RaczeQ merged commit d160b3c into main Feb 2, 2024
9 of 10 checks passed
@RaczeQ RaczeQ deleted the fix-grouped-osm-tags-filter-with-keep-all-tags branch February 2, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant