add comments to the Crontab class in crontab.py and the Command class in management/commands/crontab.py #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… class in `management/commands/crontab.py`
|
Hey @jiangmf, thanks for your comments but as you can see they fail to comply the pep8 rules. With just some additional spaces i'll gracefully merge them :) You should be able to run the test locally with: $ pip install flake8
$ flake8 django_crontab --ignore=E501 |
|
fixed! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added comments to improve code clarity and maintainability.
(This pull request is created as a part of an assignment for the course COMPSCI 3I03 at McMaster University)