nonclangable.conf: Add new exceptions #702
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "pciutils" for riscv64 architecture Add "erlang" for all architectures (found on riscv64 and x86-64) Add "grub" for x86-64 architecture Use proper OBJCOPY for "linux-yocto" for all architectures Signed-off-by: Aleksey Smirnov <aleksey.smirnov@yadro.com>
kraj
approved these changes
Dec 9, 2022
kraj
reviewed
Dec 12, 2022
| @@ -1,3 +1,20 @@ | |||
| #| clang-15: error: unable to execute command: Segmentation fault (core dumped) | |||
| #| clang-15: error: linker command failed due to signal (use -v to see invocation) | |||
| TOOLCHAIN:pn-pciutils:riscv64 = "gcc" | |||
There was a problem hiding this comment.
I can build pciutils fine with clang-15 from master branch. So I wonder whats different on your system. I use yoe distribution (https://github.com/yoedistro/yoe-distro)
kraj
reviewed
Dec 12, 2022
| # run.do_uboot_mkimage.1228: 185: riscv64-yadro-linux-llvm-objcopy: not found | ||
| # FileNotFoundError: [Errno 2] No such file or directory: 'x86_64-yadro-linux-llvm-objcopy' | ||
| # both riscv64 and x86-64 | ||
| OBJCOPY:pn-linux-yocto:toolchain-clang = "${HOST_PREFIX}objcopy" |
There was a problem hiding this comment.
There already is similar setting for mips perhaps we need to remove that also if we set it globally like this.
kraj
reviewed
Dec 12, 2022
| # both riscv64 and x86-64 | ||
| TOOLCHAIN:pn-erlang = "gcc" | ||
|
|
||
| # run.do_uboot_mkimage.1228: 185: riscv64-yadro-linux-llvm-objcopy: not found |
There was a problem hiding this comment.
this comment does not match the code, its not uboot but kernel.
kraj
reviewed
Dec 12, 2022
|
I have reworked this a bit and dropped pciutils change since it works ok with clang15 on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "pciutils" for riscv64 architecture
Add "erlang" for all architectures (found on riscv64 and x86-64) Add "grub" for x86-64 architecture
Use proper OBJCOPY for "linux-yocto" for all architectures
Signed-off-by: Aleksey Smirnov aleksey.smirnov@yadro.com
Contributor checklist
Signed-off-byis presentReviewer Guidelines