Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frame: Use --undefined-version with lld #942

Merged
merged 1 commit into from
May 4, 2024
Merged

Conversation

kraj
Copy link
Owner

@kraj kraj commented May 3, 2024

symbol version script adds some X11 symbols which lld complains about since default is to report undefined symbols with lld.

Fixes
| x86_64-yoe-linux-ld.lld: error: version script assignment of 'FRAME_2.2' to symbol 'frame_x11_new' failed: symbol not defined | x86_64-yoe-linux-ld.lld: error: version script assignment of 'FRAME_2.2' to symbol 'frame_x11_delete' failed: symbol not defined | x86_64-yoe-linux-ld.lld: error: version script assignment of 'FRAME_2.2' to symbol 'frame_x11_process_event' failed: symbol not defined | x86_64-yoe-linux-ld.lld: error: version script assignment of 'FRAME_2.2' to symbol 'frame_x11_accept_touch' failed: symbol not defined | x86_64-yoe-linux-ld.lld: error: version script assignment of 'FRAME_2.2' to symbol 'frame_x11_reject_touch' failed: symbol not defined | x86_64-yoe-linux-ld.lld: error: version script assignment of 'FRAME_2.2' to symbol 'frame_x11_get_window_id' failed: symbol not defined | x86_64-yoe-linux-ld.lld: error: version script assignment of 'FRAME_2.2' to symbol 'frame_x11_create_window_id' failed: symbol not defined | x86_64-yoe-linux-ld.lld: error: version script assignment of 'FRAME_2.2' to symbol 'frame_x11_get_touch_id' failed: symbol not defined | x86_64-yoe-linux-ld.lld: error: version script assignment of 'FRAME_2.2' to symbol 'frame_x11_create_touch_id' failed: symbol not defined


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

symbol version script adds some X11 symbols which lld complains about
since default is to report undefined symbols with lld.

Fixes
| x86_64-yoe-linux-ld.lld: error: version script assignment of 'FRAME_2.2' to symbol 'frame_x11_new' failed: symbol not defined
| x86_64-yoe-linux-ld.lld: error: version script assignment of 'FRAME_2.2' to symbol 'frame_x11_delete' failed: symbol not defined
| x86_64-yoe-linux-ld.lld: error: version script assignment of 'FRAME_2.2' to symbol 'frame_x11_process_event' failed: symbol not defined
| x86_64-yoe-linux-ld.lld: error: version script assignment of 'FRAME_2.2' to symbol 'frame_x11_accept_touch' failed: symbol not defined
| x86_64-yoe-linux-ld.lld: error: version script assignment of 'FRAME_2.2' to symbol 'frame_x11_reject_touch' failed: symbol not defined
| x86_64-yoe-linux-ld.lld: error: version script assignment of 'FRAME_2.2' to symbol 'frame_x11_get_window_id' failed: symbol not defined
| x86_64-yoe-linux-ld.lld: error: version script assignment of 'FRAME_2.2' to symbol 'frame_x11_create_window_id' failed: symbol not defined
| x86_64-yoe-linux-ld.lld: error: version script assignment of 'FRAME_2.2' to symbol 'frame_x11_get_touch_id' failed: symbol not defined
| x86_64-yoe-linux-ld.lld: error: version script assignment of 'FRAME_2.2' to symbol 'frame_x11_create_touch_id' failed: symbol not defined

Signed-off-by: Khem Raj <raj.khem@gmail.com>
@kraj kraj merged commit ad26539 into kraj:master May 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant