Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise an error if buildscript() is called not from the root project #124

Closed
NiklasRosenstein opened this issue Oct 9, 2023 · 0 comments · Fixed by #130
Closed

Raise an error if buildscript() is called not from the root project #124

NiklasRosenstein opened this issue Oct 9, 2023 · 0 comments · Fixed by #130
Assignees
@NiklasRosenstein
Labels
only: kraken-common This issue affects only kraken-common. type: enhancement New feature or request

Comments

@NiklasRosenstein
Copy link
Contributor

People that are not very familiar with Kraken that write a .kraken.py for a sub-project will often copy the buildscript() block into that script, but it's only required at the top-level. We should just raise an exception when it is used in any project that is not the root project, as it doesn't add any value there.
@NiklasRosenstein NiklasRosenstein added type: enhancement New feature or request only: kraken-common This issue affects only kraken-common. labels Oct 9, 2023
@NiklasRosenstein NiklasRosenstein self-assigned this Oct 9, 2023
@NiklasRosenstein NiklasRosenstein mentioned this issue Nov 8, 2023
Merged
@NiklasRosenstein NiklasRosenstein linked a pull request Nov 8, 2023 that will close this issue
kraken-build/: improvement: Calling buildscript() from a Kraken project that is not the root project will now raise a RuntimeError. #130
Merged
NiklasRosenstein added a commit that referenced this issue Dec 11, 2023
@NiklasRosenstein
Fix RuntimeError caused by running krakenw after the changes intr…
00c63af 
…oduced in #124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NiklasRosenstein NiklasRosenstein

Labels
only: kraken-common This issue affects only kraken-common. type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@NiklasRosenstein