Use non-strict mode when parsing .gitconfig #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 11, 2023 10:36
By default, configparser will raise when encountering the same section several times. There is no reason to do so here, and we can just merge the occurrences. This is done by passing strict=False to the configuration parser.
NiklasRosenstein
approved these changes
Dec 11, 2023
|
I have a failure with isort in the CI (ran thrice to be sure), but not locally. Is it possible that the isort version differs between the context, or is its version pinned? |
|
Just had to merge in develop :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recognize that my
~/.gitconfigis a bit messy, but it has never been a problem before. This PR ensure that it works with kraken-build as well, removing a potential friction for users.By default, configparser will raise when encountering the same section several times. There is no reason to do so here, and we can just merge the occurrences. This is done by passing strict=False to the configuration parser.