Fix kraken run -X <task> option to correctly not mark a required task as skipped
#138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AG that failed the expected behavior of `TaskGraph.mark_tasks_as_skipped()`.
…mpler implementation that also fixes an issues with second-degree tasks being marked as skipped even if they should not be.
skip-checks: true
NiklasRosenstein
changed the title
kraken run -X <task> option to correctly not mark a required task as skipped
|
Something we should consider eventually as a follow up: If you mark a task as skipped that is required to run for a successor task (e.g. if it provides an output property), the subsequent task will fail. The error message will be a bit obscure in this case (e.g. "Property value will be known at a later time") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TaskGraph.mark_tasks_as_skipped().Tasks.mark_tasks_as_skipped()with a simpler implementation that also fixes an issues with second-degree tasks being marked as skipped even if they should not be.