feat: add flags to clippy to cover more cases #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkarw
added
type: enhancement
tomkarw
force-pushed
the
tomkarw/better-coverage-with-clippy
branch
from
605a6a6
to
6722ab4
Compare
* --workspace, tests whole workspace, important as for non-virtual workspace clippy will lint root crate only * --all-features, tests with all features enabled, important to prevent commiting broken code behind a feature flag * -- -D warnings, fail on warnings, should be the default behaviour in pipelines
tomkarw
force-pushed
the
tomkarw/better-coverage-with-clippy
branch
from
6722ab4
to
4536737
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--workspace, tests whole workspace, important as for non-virtual workspace clippy will lint root crate only--all-features, tests with all features enabled, important to prevent committing broken code behind a feature flag-- -D warnings, fail on warnings, should be the default behavior in pipelinesAfter internal discussions I opted against setting
deny_warningstoTrueby default, so no "breaking changes" here. Defaulting toTruefor--workspaceand--all-featuresthus also won't break anything, and should be set by default, as its absence is basically a foot-gun.