Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix that pyproject.toml is continuously outdated in certain cases #221

Merged
merged 6 commits into from
Mar 15, 2024

Conversation

NiklasRosenstein
Copy link
Contributor

@NiklasRosenstein NiklasRosenstein commented Mar 15, 2024

Sometimes the pyproject.toml would add or remove some newlines, in certain cases also be continuously outdated, never satisfying the pyproject.check task. This is because we converted the top-level tomlkit container that keeps track of formatting to a standard Python dict.

@NiklasRosenstein NiklasRosenstein changed the title fix: Fix that updating the pyproject.toml is continuously outdated in certain cases fix: Fix that pyproject.toml is continuously outdated in certain cases Mar 15, 2024
@NiklasRosenstein
Copy link
Contributor Author

Now that we're using a MutableMapping as the base class for Pyproject since #223, setdefault() behaves differently as explained in python-poetry/tomlkit#49 (comment).

Need to override setdefault(), although I fear we might hit other incompatibilities issues down the road.. (This is the second, after #223).

@NiklasRosenstein NiklasRosenstein merged commit 2dd6c96 into develop Mar 15, 2024
13 of 16 checks passed
@NiklasRosenstein NiklasRosenstein deleted the nr/fix-pyproject-write branch March 15, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant