Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the name of EventHandler class #28

Closed
khelle opened this issue Sep 27, 2016 · 0 comments
Closed

Change the name of EventHandler class #28

khelle opened this issue Sep 27, 2016 · 0 comments
Assignees

Comments

@khelle
Copy link
Member

khelle commented Sep 27, 2016

In theory, event-driven architecture uses sets of event emitters and event listeners to communicate using events. Kraken official documenatation refers to these two types of objects the same. However, in implementation there is EventEmitter and - misleadingly - EventHandler. Therefore, EventHandler should be renamed to EventListener to keep implementation consistent to documentation and as near as possible to theoretical implementation.

@khelle khelle self-assigned this Sep 27, 2016
@khelle khelle closed this as completed in a537a1c Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant