Add type to JWT decode header

[AlyHKafoury]

reference : krakend/krakend-ce#711

[taik0]

Hi @AlyHKafoury can you add the requested changes?

Thank you!

[AlyHKafoury]

Hi @AlyHKafoury can you add the requested changes?

Thank you!

I have added the required changes, can I ask for your review please ?

[AlyHKafoury]

I am fixing the tests problems

[AlyHKafoury]

@kpacha is there a correct method to generate the signed JWT payloads for tests ?

[kpacha]

There are some keys at the fixtures folder. you can use symmetric or asymmetric alg. you can instantiate a Signer (https://github.com/krakend/krakend-jose/blob/master/gin/jose.go#L24) and use it to sign your test token

[alombarte]

Hi @AlyHKafoury, we have selected this feature to release with KrakenD 2.5, which will be out really soon. Will you be able to complete the tests?

[AlyHKafoury]

Hello, Yes I will push it in a few hours Best Regards, Aly Kafoury

…

On Mon, Oct 23, 2023 at 1:41 PM A. Lombarte ***@***.***> wrote: Hi @AlyHKafoury <https://github.com/AlyHKafoury>, we have selected this feature to release with KrakenD 2.5, which will be out really soon. Will you be able to complete the tests? — Reply to this email directly, view it on GitHub <#119 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIKUBD4DBVMBGEKBAOEZJKTYAZCUZAVCNFSM6AAAAAA2QLRQFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZUHEYTKMRUGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[alombarte]

Hello @AlyHKafoury,

We will be preparing the release of KrakenD CE 2.5 early next week. I just wanted to ping you to see if you can complete this. Otherwise we will introduce this functionality in krakenD 2.6 (2024)

[alombarte]

Hi @AlyHKafoury,

Are you still interested in finishing this for the next release 2.6?

[AlyHKafoury]

Yes I will do my best to fix the unit tests I am just not very familiar with the key generation

[AlyHKafoury]

@alombarte I made changes to the test case encryption once it is reviewed I believe the code should pass the test case passes locally now

[AlyHKafoury]

@kpacha can you please re-review

[AlyHKafoury]

@alombarte Will re run the signer

[kpacha]

@AlyHKafoury I've created a PR on your fork fixing the failling tests. Once you approve and merge it, we'll be able to merge and close this PR

[kpacha]

Thanks for the contribution!!!