Add JWT scopes validation #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests
|
PR for #47. |
|
Unfortunately, this also adds now some redundancy - I am aware of that. Especially regarding the "roles" validation feature. But I did not want to change that on top without getting some feedback on that feature. |
|
Please, accept this PR. It is an important feature. In fact, I am in need of it right now. |
|
thanks for the contribution, @cdennig let's update the CE and then we can revisit the implementation and look for redundant code |
|
Sure...I can make a suggestion, but it'll take some time for me. I'm pretty busy atm. |
|
This pull request was marked as resolved a long time ago and now has been automatically locked as there has not been any recent activity after it. You can still open a new issue and reference this link. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to validate scopes in a JWT token. The key for the scopes claim can be customized ("scopes_key" property) and the value can be read from a nested property in the token (same as for "role" validation). Additionally, the matching function can be customized: "any" returns "true" when at least one of the required scopes is available in the token, "all" means that all required scopes need to be included.
If the validation fails, a 403 will be returned.
Tests have been added.