Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS SDK version update #11

Merged
merged 5 commits into from Jul 5, 2022
Merged

AWS SDK version update #11

merged 5 commits into from Jul 5, 2022

Conversation

boris154
Copy link

Closes #9

  • Updated aws-sdk-go version to the latest one (v1.44.24).
  • Updated README with the proper lcoalstack parameters based on the official docs. Otherwise the tests didn't work on my local PC.
  • Added logger to BackendFactory in localstack_test.go

Test ran successfully.

@kpacha
Copy link
Member

kpacha commented Jun 14, 2022

nice!

can you fix the conflicts and update the pkgs from the krakendio group?

@boris154
Copy link
Author

Hey @kpacha
I did a back merge and resolved the conflicts.

@alombarte alombarte requested a review from kpacha June 21, 2022 10:21
@kpacha kpacha merged commit e08cd7e into krakend:master Jul 5, 2022
@kpacha
Copy link
Member

kpacha commented Jul 5, 2022

@boris154 thanks for the contribution!

@boris154
Copy link
Author

@kpacha Do you have an estimation on when this changes are going to be release to krakend-ce ?

@kpacha
Copy link
Member

kpacha commented Aug 30, 2022

@boris154 it should be included into the v2.1.0, expected to be released at the end of september

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpacha kpacha kpacha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IRSA support
2 participants
@boris154 @kpacha