New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invert if logic so hostname is set if os.Hostname correctly returns a value #9

Merged

kpacha merged 2 commits into krakend:master from lxdraw:set-hostname-correctly

Jan 24, 2024

Contributor

lxdraw commented Jan 22, 2024

Solves issue #8


          Invert if logic so hostname is set if os.Hostname correctly returns a…

7a64422

… value

kpacha approved these changes

View reviewed changes

Member

kpacha commented Jan 23, 2024

@lxdraw thanks for the contribution. Can you fix the failing tests so we can merge your fix?


          Fix failing logger tests

16545d5

kpacha approved these changes

View reviewed changes

kpacha merged commit 350bfc9 into krakend:master

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment