Krakend Rate Limit to Mux Based routers #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnaeverestengineering
changed the title
kpacha
reviewed
Feb 8, 2021
|
|
||
| // IPTokenExtractor extracts the IP of the request | ||
| func IPTokenExtractor(c http.ResponseWriter, r *http.Request) string { | ||
| return r.RemoteAddr |
There was a problem hiding this comment.
this token extractor implementation will return the wrong IP if the gateway is placed behind a load balancer or reverse proxy.
check this commit for more details: f82ede8
|
Thanks for the contribution and sorry for the huge delay in processing it. I don't know how I missed it! If you are no longer willing to move on with this (I'd totally understand it), I myself will add the minor modifications the code requires to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.