Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added url-sanitization function #110

Merged
merged 5 commits into from
Oct 17, 2023
Merged

feat: added url-sanitization function #110

merged 5 commits into from
Oct 17, 2023

Conversation

prashantjagasia
Copy link
Contributor

No description provided.

@prashantjagasia prashantjagasia marked this pull request as ready for review October 11, 2023 23:49
@prashantjagasia prashantjagasia requested a review from a team as a code owner October 11, 2023 23:49
spencersablan
spencersablan approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@spencersablan spencersablan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Do we need to include changes in the dist folder to belter PR's? 🤔

bdwood3
bdwood3 reviewed Oct 16, 2023
View reviewed changes
Copy link

@bdwood3 bdwood3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is using Braintree's sanitizeUrl code, so why not just use that as a dependency?
https://github.com/braintree/sanitize-url

@prashantjagasia
Copy link
Contributor Author

Looks like this is using Braintree's sanitizeUrl code, so why not just use that as a dependency? https://github.com/braintree/sanitize-url

That was the original idea but since Belter itself is a repo for utils, Shane and I decided to make this util part of our repo as well.

@prashantjagasia
Copy link
Contributor Author

Nice! Do we need to include changes in the dist folder to belter PR's? 🤔

Good callout! looks like those were for some CI. Removed them.

xuanwan05
xuanwan05 approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@xuanwan05 xuanwan05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

@prashantjagasia prashantjagasia merged commit 6dfe213 into krakenjs:main Oct 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdwood3 bdwood3 bdwood3 approved these changes

@xuanwan05 xuanwan05 xuanwan05 approved these changes

@spencersablan spencersablan spencersablan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@prashantjagasia @bdwood3 @xuanwan05 @spencersablan