[DTPPCPSDK-1334] feat: add isWebView check to supportsPopups #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravishekhar
approved these changes
Oct 25, 2023
| } | ||
| }); | ||
| it("should return false when userAgent is valid and contains 'wv' in the words only", () => { | ||
| window.navigator.userAgent = `dkdfsna/5.25.638 Dalwvik/2.1.0 (Linux; U; Android 13; SM-S908U1 Build/TP1A.220624.014;)`; |
There was a problem hiding this comment.
just a nit pick, its bit hard to notice wv is inside Dalwvik . Can you pls add a code comment.
wsbrunson
approved these changes
Oct 25, 2023
elizabethmv
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added isWebView() check to supportsPopups(), so new user agents for WebView which contains 'wv' will not support pop-ups.
Added all UA Strings to the test file.
UA does NOT support popup:
dkdfsna/5.25.638 Dalvik/2.1.0 (Linux; U; Android 13; SM-S908U1 Build/TP1A.220624.014; wv )UA supports popup :
Mozilla/5.0 (iPhone; CPU iPhone OS 10_3 like Mac OS X) AppleWebKit/602.1.50 (KHTML, like Gecko) CriOS/56.0.2924.75 Mobile/14E5239e Safari/602.1