This repository has been archived by the owner on Jan 25, 2020. It is now read-only.
Naive implementation to ignore dotfiles when scanning. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Argh, forgot tests. Pls don't merge. |
|
👍 wondering if we should check flags (OS dependent), too? |
|
I briefly considered that, but I'd rather get a short-term fix out to unblock people and we can consider a more better fix. Then we won't be time constrained. Will add comments indicating as such, tho. Also will file issue to keep track. |
totherik
added a commit
that referenced
this pull request
Jun 17, 2014
Naive implementation to ignore dotfiles when scanning.
|
Not sure what flags actually make sense there. 'hidden' in windows is extremely rare in a project space. I think just dotfiles makes sense -- besides, that way you don't get OS-dependent behaviors that change when you move code to a new environment. |
jasisk
added a commit
that referenced
this pull request
Aug 19, 2014
jasisk
added a commit
that referenced
this pull request
Dec 4, 2014
jasisk
added a commit
that referenced
this pull request
Dec 4, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.