This repository has been archived by the owner on Jan 25, 2020. It is now read-only.
(grunt) Fix missing deps #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing: grunt, grunt-contrib-jshint, grunt-tape. Updated: Gruntfile reference mocha which is not used.
|
Thanks for the PR @sixlettervariables, but the gruntfile is an unfortunate remnant from the previous version. It's not meant to be used and the current preferred way to run tests, coverage, and linting is through the npm scripts "test," "cover," and "lint." |
Closed
|
Deleting is always the simpler fix! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some missing dependencies related to the Gruntfile packaged with express-enrouten. The Gruntfile also referenced mocha, which was not used in this package. The grunt task for
tapehas been used instead.Added to
package.json:Grunt can now be used for testing and linting.