This repository has been archived by the owner on Jan 25, 2020. It is now read-only.
Add ignore support #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 1, 2016 22:22
This commit simply adds a few files that should be ignored( eg: files with no extension, files that look like they meet the API but don't) to the "ignore" fixtures directory. These files a perfectly valid use case. For example, SVN-like versioning systems populate a project with hidden folders that include such files. The pattern is: A non-empty file without an extension. These types of files will currently cause express enrouten to fail, as it will incorrectly identify them as a valid node module, and will try to load them, as well as feed them the router object.
Fixes krakenjs#73 This introduces a change to the directory configuration (It's now an {path:"path/to/controllers", ignore:['pattern1',...]} object instead of a path string. However, I made it backwards compatible. It shows a deprecation message, but we could support both methods if desired
|
|
||
| // Cast legacy config into new config. | ||
| if (typeof options.directory === 'string') { | ||
| console.error('express-enrouten:\n' + |
There was a problem hiding this comment.
Is it necessary to print this? Why not simply support a string as short hand?
There was a problem hiding this comment.
It's completely optional.
No idea if you guys want to support both methods of config. I can remove as needed.
There was a problem hiding this comment.
K, I will leave it up to whoever merges / doesn't merge.
|
Aside from comment above, LGTM. |
|
Closed due to branch renaming. Will reconstruct, reopen, and notify you when complete. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a configurable list of files to ignore.
Uses minimatch to provide shell glob patterns, similar to .*ignore files.
Basically, instead of simply specifying the path to the directory, you can now optionally provide an array like:
Another proposal to fix #73
If this looks OK, I'll write in the documentation updates before it's merged.