Skip to content
This repository has been archived by the owner on Jan 25, 2020. It is now read-only.

Awaiting mocha release with fixed timeout(0) regression #120

Closed
jasisk opened this issue Aug 18, 2014 · 2 comments
Closed

Awaiting mocha release with fixed timeout(0) regression #120

jasisk opened this issue Aug 18, 2014 · 2 comments

Comments

@jasisk
Copy link
Member

jasisk commented Aug 18, 2014

Related to #118 and mochajs/mocha#1300.

Presently, timeout(0) in mocha doesn't act as documented, subsequently breaking out tests. To workaround the issue I pegged mocha to ~1.20 in 0d89749.

Issue to be resolved in the next mocha release as demonstrated by mochajs/mocha@4c0c479 and mochajs/mocha@35da58b.

@fujifish
Copy link

fujifish commented Sep 6, 2014

Passing "-timeout 0" on the command line should disable timeouts, but since timeout(0) doesn't have that effect - all tests fail.

As a workaround, we call enableTimeouts(false) at the beginning of the suite if the timeout is 0:

if (this.timeout() === 0) {
  this.enableTimeouts(false);
}

@grawk
Copy link
Member

grawk commented Jun 27, 2016

resolved with #208 (mocha had fixed the core issue a while ago but this PR modifies the this.timeout statements in the tests)

@grawk grawk closed this as completed Jun 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants