Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: timeout of 0ms exceeded #1300

Closed
rook2pawn opened this issue Aug 4, 2014 · 4 comments · Fixed by krakenjs/generator-kraken#208
Closed

Error: timeout of 0ms exceeded #1300

rook2pawn opened this issue Aug 4, 2014 · 4 comments · Fixed by krakenjs/generator-kraken#208

Comments

@rook2pawn
Copy link

Getting this error when specifiying

this.timeout(0)

Which normally disables timeouts altogether, now it is interpreting it literally.

@vdamyanov
Copy link

+1

@ksmithut
Copy link

ksmithut commented Aug 5, 2014

Also, negative numbers don't disable it, although I don't know if that was actually a thing before.

travisjeffery added a commit that referenced this issue Aug 6, 2014
resolves #1300: passing 0 to timeout() will disable timeouts
@skeggse
Copy link
Contributor

skeggse commented Aug 14, 2014

It looks like this doesn't work for beforeEach hooks. The following test fails.

describe('acceptance', function() {
  this.timeout(0);

  beforeEach(function(done) {
    setTimeout(done, 1);
  });

  it('should not fail', function() {});
});

EDIT: this test also fails.

describe('acceptance', function() {
  this.timeout(0);

  describe('inner', function() {
    it('should not fail', function(done) {
      setTimeout(done, 1);
    });
  });
});

I can move this to a separate issue if you want.

@boneskull boneskull reopened this Aug 15, 2014
@skeggse
Copy link
Contributor

skeggse commented Aug 15, 2014

Thanks!

tandrewnichols pushed a commit to tandrewnichols/mocha that referenced this issue Dec 15, 2014
tandrewnichols pushed a commit to tandrewnichols/mocha that referenced this issue Dec 15, 2014
grawk added a commit to krakenjs/generator-kraken that referenced this issue Jun 27, 2016
grawk added a commit to krakenjs/generator-kraken that referenced this issue Jun 29, 2016
* update license to reflect PayPal OSS

* fix for #206

* upgrade travis node versions

* use yeoman-test and yeoman-assert modules per deprecation warnings

* use this.timeout(0) in tests as mocha has fixed issue mochajs/mocha#1300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants