Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for graceful shutdowns #7

Closed
totherik opened this issue Nov 19, 2013 · 3 comments
Closed

Add support for graceful shutdowns #7

totherik opened this issue Nov 19, 2013 · 3 comments

Comments

@totherik
Copy link
Member

Not totally sure where the behavior belongs, but we want to be able to stop the server from accepting connections and allowing it to drain existing connections before exiting. We can do this a number of ways, but adding a hook for a process signal seems most straightforward:

Add hook for an agreed upon signal (SIGTERM?)
Stop server (prevent new connections)
Add 'Connection: close' to all existing connection responses after server.close().
Once server closes, exit process with appropriate status code

@lensam69
Copy link
Contributor

@tlivings
Copy link
Member

Should listen for both SIGINT (Control-C) as well as SIGTERM.

jeffharrell added a commit that referenced this issue Dec 9, 2013
[Issue #7] Add support for graceful shutdowns.
@jeffharrell
Copy link
Member

This is now resolved as part of #21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants