Adding fix and regression test for trust proxy fn
clobbering
#208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of a change made in express and proxy-addr, our clobbering of app.settings was causing
a problem (
trust proxy fn
was never being set). This fix re-adds thetrust proxy
setting,post-clobbering, to ensure express does what it needs to do.
We may want to change to iterating over our
express
config entries and.set
ing them one-by-onein the future, but this works for now.