-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue #7] Add support for graceful shutdowns. #21
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d5b92cf
[Issue #7] Add support for graceful shutdowns.
sean e836a66
Merge pull request #29 from jgable/updateLifecycleDocs
lensam69 5482ea5
[Issue #7] Add support for graceful shutdowns.
sean b75a841
[Issue #7] Add support for graceful shutdowns. Incorporated review fe…
sean 44d7df9
[Issue #7] Add support for graceful shutdowns. Incorporated review fe…
sean 6356de3
[Issue #7] Add support for graceful shutdowns. Incorporated review fe…
sean cc60f66
[Issue #7] Add support for graceful shutdowns. Incorporated review fe…
sean b27163a
[Issue #7] Incorporated review feedback from @jeffharrell
sean File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
/***@@@ BEGIN LICENSE @@@***/ | ||
/*───────────────────────────────────────────────────────────────────────────*\ | ||
│ Copyright (C) 2013 eBay Software Foundation │ | ||
│ │ | ||
│hh ,'""`. │ | ||
│ / _ _ \ Licensed under the Apache License, Version 2.0 (the "License"); │ | ||
│ |(@)(@)| you may not use this file except in compliance with the License. │ | ||
│ ) __ ( You may obtain a copy of the License at │ | ||
│ /,'))((`.\ │ | ||
│(( (( )) )) http://www.apache.org/licenses/LICENSE-2.0 │ | ||
│ `\ `)(' /' │ | ||
│ │ | ||
│ Unless required by applicable law or agreed to in writing, software │ | ||
│ distributed under the License is distributed on an "AS IS" BASIS, │ | ||
│ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. │ | ||
│ See the License for the specific language governing permissions and │ | ||
│ limitations under the License. │ | ||
\*───────────────────────────────────────────────────────────────────────────*/ | ||
/***@@@ END LICENSE @@@***/ | ||
'use strict'; | ||
|
||
module.exports = function (app, settings, template) { | ||
|
||
var gracefulShutdown = function () { | ||
settings.set('kraken:shuttingDown', true); | ||
console.log("Received kill signal, shutting down gracefully."); | ||
var server = app.get('kraken:server'); | ||
// switch to kraken.close once it's implemented | ||
server.close(function () { | ||
console.log("Closed out remaining connections."); | ||
process.exit(); | ||
}); | ||
|
||
setTimeout(function () { | ||
console.error("Could not close connections in time, forcefully shutting down."); | ||
process.exit(1); | ||
}, 30 * 1000); | ||
}; | ||
|
||
process.on("SIGTERM", gracefulShutdown); | ||
process.on("SIGINT", gracefulShutdown); | ||
|
||
return function (req, res, next) { | ||
if (!settings.get('kraken:shuttingDown')) { | ||
return next(); | ||
} | ||
res.setHeader("Connection", "close"); | ||
if (template && !req.xhr) { | ||
res.status(503); | ||
res.render(template); | ||
} else { | ||
res.send(503, "Server is in the process of restarting."); | ||
} | ||
}; | ||
|
||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with the team.
Thanks!
Just a minor nitpick on this line: Should it say "shutting down" instead of "restarting"?