Add deprecation warning to 404/5xx middleware #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These middleware cause more problems than they solve. Because they're everywhere, I'd like to keep them in place for another major. The default express handler is sufficient in many cases. This is more a documentation issue than anything else (and one we've already addressed in the generator). Closes #359.
|
Awesome. 👍 |
|
👍 |
jasisk
added a commit
that referenced
this pull request
Apr 8, 2015
Add deprecation warning to 404/5xx middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These middleware cause more problems than they solve.
Because they're everywhere, I'd like to keep them in place for another
major. The default express handler is sufficient in many cases. This is
more a documentation issue than anything else (and one we've already
addressed in the generator).
Closes #359.