Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable favicon in config/middleware.json #47

Closed
wants to merge 3 commits into from
Closed

Configurable favicon in config/middleware.json #47

wants to merge 3 commits into from

Commits on Dec 5, 2013

  1. Configurable favicon in config/middleware.json 

    Setting favicon:"" disables express.favicon() so requests can be served as
static files, otherwise the value is passed on as favicon file path argument.
    @AlbertoGP
    AlbertoGP committed Dec 5, 2013
    Configuration menu
    Copy the full SHA
    592206e View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2013

  1. Configurable favicon: reformat code for jshint tests

    @AlbertoGP
    AlbertoGP committed Dec 6, 2013
    Configuration menu
    Copy the full SHA
    d487339 View commit details
    Browse the repository at this point in the history

  2. Back to the original idea of using boolean false 

    as the way to tell Kraken not to use the favicon middleware.
The only reason for switching to an empty string at the last minute
was a misunderstanding on my part of the JSON specification.
    @AlbertoGP
    AlbertoGP committed Dec 6, 2013
    Configuration menu
    Copy the full SHA
    0473647 View commit details
    Browse the repository at this point in the history