Include process.cwd() while resolving module for view engine #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumeetkakkar
force-pushed
the
topic/resolve-module
branch
from
9e235d0
to
8a91ec4
Compare
…sible that krakenjs module is deployed outside application root
sumeetkakkar
force-pushed
the
topic/resolve-module
branch
from
8a91ec4
to
2d87029
Compare
kumarrishav
reviewed
Nov 17, 2021
| return require.resolve(modulePath, { paths }); | ||
| } catch (e) { | ||
| if (e.code === 'MODULE_NOT_FOUND') | ||
| return; |
There was a problem hiding this comment.
when will this happen? and why are we silencing this error?
There was a problem hiding this comment.
never mind. I see you have a check in Line 58
There was a problem hiding this comment.
It will throw later throw new TypeError( Module ${spec.module} not found ); LINE#59
kumarrishav
approved these changes
Nov 22, 2021
grawk
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include process.cwd() while resolving module for view engine.
Before this change, if kraken-js was deployed outside the app's directory, it was not able to resolve view-engine modules deployed under app's node_modules directory.
Added unit test to test this case.