Add support for CSP nonces #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
both/either style/script src options
gabrielcsapo
suggested changes
Aug 7, 2017
index.js
Outdated
|
|
||
|
|
||
| /** | ||
| * Outputs all security headers based on configuration | ||
| * @param {Object} options The configuration object. | ||
| */ | ||
| var lusca = module.exports = function (options) { | ||
| var headers = []; | ||
| var headers = [], nonce; |
There was a problem hiding this comment.
can we separate the declarations?
index.js
Outdated
| nonce = true; | ||
| } | ||
|
|
||
| //if (key === 'csp' && lusca[key](config) && lusca[key](config)[styleNonce]) |
There was a problem hiding this comment.
can we remove the dead code?
index.js
Outdated
| @@ -46,6 +58,7 @@ var lusca = module.exports = function (options) { | |||
| return; | |||
| } | |||
| header(req, res, next); | |||
There was a problem hiding this comment.
can we change this from
header(req, res, next)
return
to
return header(req, res, next);
| @@ -27,6 +29,22 @@ module.exports = function (options) { | |||
| } | |||
|
|
|||
| return function csp(req, res, next) { | |||
| if (styleNonce) { | |||
There was a problem hiding this comment.
maybe we can split these if statements into util functions for easier testing?
There was a problem hiding this comment.
meh, it hurts the readability imo. also forces the res object to be passed around more than is necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
both/either style/script src options