Support koa style middleware #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
express is still about 100 times more popular by npm downloads (at least on week days). Supporting koa adds a lot of complexity to this module. Would it not make more sense to just add koa-lusca? |
|
+1 for koa-lusca. And is it better to split a module |
|
It's easy to make a koa-lusca, but I want to reuse the same codes and logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
koa is become more and more popular, it's time to support the new style middlewares.
options.koa = trueBecause
node 0.10.xdon't support--harmony, current unit test only pass onnode 0.11.x.$ npm run test-express: only test express$ npm run test-koa: only test koa$ npm test: test express and koa both