Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated HSTS to support the preload flag #51

Merged
merged 2 commits into from
Apr 18, 2015
Merged

Updated HSTS to support the preload flag #51

merged 2 commits into from
Apr 18, 2015

Conversation

amotmot
Copy link
Contributor

@amotmot amotmot commented Apr 18, 2015

Hey, I've updated the HSTS implementation to support the preload flag. This flag is required for HSTS domain submissions to Chrome's preload list. The changes include new feature support, new test case, and updated docs. More information regarding preload is available below

https://hstspreload.appspot.com/

@aredridel
Copy link
Contributor

Wow, great PR. 👍

@pvenkatakrishnan
Copy link
Member

thanks for the pr! there seems to be a lint error. can you check running grunt test ?

Fixed lint error
@amotmot
Copy link
Contributor Author

amotmot commented Apr 18, 2015

@pvenkatakrishnan, I've fixed the lint error.

@pvenkatakrishnan
Copy link
Member

thanks merging.

pvenkatakrishnan added a commit that referenced this pull request Apr 18, 2015
 Updated HSTS to support the preload flag
@pvenkatakrishnan pvenkatakrishnan merged commit da93242 into krakenjs:master Apr 18, 2015
@amotmot amotmot deleted the preload branch April 18, 2015 17:13
@amotmot
Copy link
Contributor Author

amotmot commented Apr 25, 2015

@pvenkatakrishnan or @aredridel how long before this change makes its way to npm i lusca? I'm not seeing the preload logic after a npm install.

@aredridel
Copy link
Contributor

The lead maintainer is at a conference, but I bet we can track him down in the next few days!

@jasisk
Copy link
Member

jasisk commented Apr 25, 2015

Hi @gellerb,

I was tracked down. :) Published as v1.1.0.

@amotmot
Copy link
Contributor Author

amotmot commented Apr 26, 2015

@jasisk Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants