Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plain JS config no longer merges top-level data #52

Closed
dwbruhn opened this issue Dec 7, 2018 · 0 comments
Closed

Plain JS config no longer merges top-level data #52

dwbruhn opened this issue Dec 7, 2018 · 0 comments

Comments

@dwbruhn
Copy link
Collaborator

dwbruhn commented Dec 7, 2018

With the JSON config, a top-level data section would be merged with nemo.data at runtime, which was a neat way to set default data, even when running parallel by data:

{
    "plugins": {
        "view": {
            "module": "nemo-view",
            "arguments": [
                "path:locator"
            ]
        }
    },
    "output": {
        "reports": "path:report"
    },
    "data": {
        "THIS_WILL_SHOW_UP_IN_NEMO_DATA": 1
    },
    "profiles": {
// etc.

With the plain JS config, top-level data doesn't get merged with the runtime nemo.data:

const path = require("path");

module.exports = {
    plugins: {
        view: {
            module: "nemo-view"
        }
    },
    output: {
        reports: path.resolve("test/nemo2", "report")
    },
    data: {
        THIS_NEVER_SHOWS_UP_IN_NEMO_DATA: 1
    },
    profiles: {
        base: {
            tests: path.resolve("test/nemo2", "*test.js"),
            driver: {
                browser: "chrome"
            },
            data: {
                baseUrl: "https://www.google.com"
            },
            mocha: {
                timeout: 180000,
                reporter: "mochawesome",
                reporterOptions: {
                    quiet: true
                }
            }
        }
    }
};
grawk added a commit that referenced this issue Dec 10, 2018
@grawk grawk mentioned this issue Dec 10, 2018
@grawk grawk closed this as completed in #55 Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant