Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coerce for booleans #42

Merged
merged 1 commit into from
Sep 2, 2015
Merged

Fix coerce for booleans #42

merged 1 commit into from
Sep 2, 2015

Conversation

yodeyer
Copy link
Contributor

@yodeyer yodeyer commented Aug 7, 2015

coercion() method doesn't work with parameters of type boolean.
A string with value 'false' was coerced to true because not empty strings are truthy.

@yodeyer yodeyer changed the title fix coerce for booleans Fix coerce for booleans Aug 8, 2015
@bg-o
Copy link

bg-o commented Sep 2, 2015

👍

tlivings added a commit that referenced this pull request Sep 2, 2015
@tlivings
Merge pull request #42 from worldline/fixBoolean
6b5fe53 
Fix coerce for booleans
@tlivings tlivings merged commit 6b5fe53 into krakenjs:master Sep 2, 2015
@tlivings
Copy link
Member

tlivings commented Sep 2, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yodeyer @bg-o @tlivings @jean-michel-apeupres