Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to enjoi 3.x depdendency #95

Closed
wants to merge 2 commits into from
Closed

Conversation

dtzar
Copy link

@dtzar dtzar commented May 22, 2018

This resolves the vulnerability problem listed here: #94
The fix from @iamjoeker only resolves the problem with the enjoi itself while swaggerize-routes still uses the 1.x version of enjoi which has the downstream dependency problem.

@ESRogs
Copy link

ESRogs commented Jun 14, 2018

@dtzar Do you know why this build failed?

(Would love to see this merged, to fix the security vulnerability!)

@jkingoliver
Copy link

enjoi is now up to 4.0.0. We'd also love to see this package updated to fix security vulnerabilities.

@computnik
Copy link

computnik commented Oct 2, 2018

+1
Any updates on this? Would love to see this merged soon!
@dtzar seems build is failing.

@dtzar
Copy link
Author

dtzar commented Oct 2, 2018

Yes, the build failed with the latest 3.x and fails in a different way with 4.x. It needs more work / debugging - I just haven't had the time to get to it.

@tlivings
Copy link
Member

tlivings commented Oct 8, 2018

I think the better path here is to get the 2.x branch merged. maintainers have been absent though.

@otroyko
Copy link

otroyko commented Dec 28, 2018

Any updates on this PR? Security vulnerability fix, please merge it ASAP.

@dtzar
Copy link
Author

dtzar commented Dec 6, 2019

Considering no PRs have been approved/merged in a VERY long time, I'm going to assume this package is no longer supported. Therefore, I don't have the desire to troubleshoot why the tests are failing for the dependency updates. So, I'll close my PR out. If the kraken-js team or whomever has contributor rights to this repo fixes the maintainer problem #89 I'll consider investing time to complete this.

@dtzar dtzar closed this Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants