Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation on apcu ini settings #349

Closed
nikic opened this issue Nov 21, 2018 · 8 comments
Closed

Update documentation on apcu ini settings #349

nikic opened this issue Nov 21, 2018 · 8 comments

Comments

@nikic
Copy link
Collaborator

nikic commented Nov 21, 2018

http://php.net/manual/en/apcu.configuration.php seems to be mostly copied from the APC docs and a lot of things refer to the no longer existing file cache. Furthermore a number of ini settings like apc.rfc1867 no longer exist (at least in apcu 5.1.x).

@andypost
Copy link

Does it makes sense to split apc and apcu this days? I seen few times apcu_bc still used

@AliceSync
Copy link

I think you need to provide some detailed configuration information, and I will update it.

@williamdes
Copy link

That would be nice to remove that from the documentation, I was thinking that apc.rfc1867 was still working

@nikic
Copy link
Collaborator Author

nikic commented Apr 28, 2021

@williamdes These have already been removed quite a while ago in php/doc-en@7ff4c27. Which documentation are you looking at?

@williamdes
Copy link

@williamdes These have already been removed quite a while ago in php/doc-en@7ff4c27. Which documentation are you looking at?

Thank you for your kind response, it is in

apcu/INSTALL

Line 292 in b68953c

apc.rfc1867 RFC1867 File Upload Progress hook handler is only available

Because it is still shipped with the extension I still had some hope

Could you give me an official confirmation that apcu has no way to provide upload progress so I can remove the code from phpMyAdmin?
And the two only methods are uploadprogress from pecl and session upload progress

(sorry if that falls a bit off topic)

@nikic
Copy link
Collaborator Author

nikic commented Apr 28, 2021

@williamdes I've deleted that INSTALL file in c2ca04f, it was pretty outdated. And yes, there is no upload progress support in apcu.

Also going to close this issue, as I think it's been mostly addressed in the meantime...

@nikic nikic closed this as completed Apr 28, 2021
@LionsAd
Copy link
Contributor

LionsAd commented Apr 29, 2021

@williamdes Also really off-topic, but: Why don’t you use a JS based upload progress method like dropzoneJS or many others instead of relying on the server capabilities?

(huge fan of PHPMyAdmin hence wanting to give feedback - sorry for the noise Niki)

@williamdes
Copy link

@williamdes Also really off-topic, but: Why don’t you use a JS based upload progress method like dropzoneJS or many others instead of relying on the server capabilities?

(huge fan of PHPMyAdmin hence wanting to give feedback - sorry for the noise Niki)

This is a very good question I also asked myself, maybe we should use some JS lib. I did a quick search some days ago and I think that http://www.resumablejs.com/ is a better choice, the actual PHP code is old and not maintained but since I re-wrote some of it that could be a solution: https://github.com/code-lts/resumable.php

huge fan of PHPMyAdmin hence wanting to give feedback

yay !

I think the conclusion is that old code needs to be replaced but keeping in mind all the previous upload methods still have to work, etc.. 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants