Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ENXIO on lx-branded zones #64

Merged
merged 1 commit into from Dec 5, 2016
Merged

Support ENXIO on lx-branded zones #64

merged 1 commit into from Dec 5, 2016

Conversation

geek
Copy link
Contributor

@geek geek commented Dec 3, 2016

Related to TritonDataCenter/sdc-docker#91

ENXIO is returned on illumos by ioctl, which gets called by tcsetgrp. This occurs when using tini inside a docker container running on lx-branded zones on illumos.

Here are a couple of docker images to help prove this out:
Before fix: d0cker/test-dtrace:1.1.1
After fix: d0cker/test-dtrace:1.1.2

With d0cker/test-dtrace:1.1.1 image:

[INFO  tini (1)] Spawned child process 'node' with pid '52187'
[FATAL tini (52187)] tcsetpgrp failed: No such device or address
[DEBUG tini (1)] Received SIGCHLD
[DEBUG tini (1)] Reaped child with pid: '52187'
[INFO  tini (1)] Main child exited normally (with status '1')
[TRACE tini (1)] No child to wait
[TRACE tini (1)] Exiting: child has exited

With d0cker/test-dtrace:1.1.2 image:

[INFO  tini (1)] Spawned child process 'node' with pid '28463'
[DEBUG tini (28463)] gpid: 27999
Listening at http://localhost:8080

@krallin
Copy link
Owner

krallin commented Dec 5, 2016

Thanks @geek, this is great!

There's a little typo in here but I'll fix in a separate commit; should I add you to the contributor list as well?

Cheers,

@krallin krallin merged commit d6938f1 into krallin:master Dec 5, 2016
@geek
Copy link
Contributor Author

geek commented Dec 6, 2016

@krallin yes please!

@krallin
Copy link
Owner

krallin commented Dec 6, 2016

Done 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants