Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change path to MP3 bootsound #1

Closed
shadow2560 opened this issue Sep 9, 2019 · 7 comments
Closed

Change path to MP3 bootsound #1

shadow2560 opened this issue Sep 9, 2019 · 7 comments

Comments

@shadow2560
Copy link

I think that the path to the bootsound should be changed to "sdmc:///config/BootSoundNX/bootsound.mp3" because the "bootloader" folder is used by Hekate and I think it was not a good idea to use this folder for the module. Also, the type of path that I propose is used by a lot of modules and I think it's a good thing to "normalize" this type of path.

@KranKRival
Copy link
Owner

KranKRival commented Sep 9, 2019

next release will have that path :)

besides it will support .ini so everyone can change the path to desired one

ill keep the request open for now
thank you.

@shadow2560
Copy link
Author

Good point for the ini file. An other little thing (I don't want to open an other issue for this), the MAKEFILE have a problem because the module is not compiled as a sysmodule, in the actual config of the project you should add the line "CONFIG_JSON := sysmodule.json" to compile it (you could also rename the "sysmodule.json" file to "config.json" or "BootSoundNX.json" to have the same result).

@KranKRival
Copy link
Owner

oh i just forgot to rename the json ^^

@KranKRival
Copy link
Owner

KranKRival commented Sep 17, 2019

sorry for the delay with this , as i have many projects and kinda limited free time , ill take care of this today or max at the week end

@shadow2560
Copy link
Author

No problem, take your time, it's not like it's a big issue and I have already made my own compilation with a temporary change for the path of the MP3 file.

@fennectech
Copy link

ane new issues with kosmos toolbox i found

@KranKRival
Copy link
Owner

KranKRival commented Sep 18, 2019

fixed all addressed issues , thank you guys :)

please check v1.1.0 release notes there is all the info.

Closed !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants