-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use the calling context #6
Comments
When nothing is selected, it uses the whole line. |
maybe we could just reuse ctrl+w feature for it, but then why not just click once or twice on ctrl+w and then use the plugin action? |
Is it possible to somehow attached to Expressions similar to the action of the "Extract Variable"? |
yeah, I could select any identifier (variable, field, method,...) or string literal (that thing between "...") under a caret in java files. |
Perhaps we are talking about different things. I'm talking about is: https://habrastorage.org/files/001/229/b81/001229b8161c4f7eb76b1f4d0a981a71.png |
Oh yeah this, probably doable, but it seems unnecessary, if you are on a identifier or on a string, then it does not make sense to convert anything more than that. |
I implemented smarter selections for java, properties files, and some generic support. |
it was just released. |
origin code:
Sets the cursor to "testSub" in line 5 (the word is not highlighted) (screenshot)
calling the action "To Constant Style"
expect:
actual (not only incorrect transformation, but also "broken" code):
The text was updated successfully, but these errors were encountered: