catch all exceptions, not just those that inherit from StandardError

krasnoukhov · Aug 28, 2013 · dbe83c0 · dbe83c0
1 parent 8496fac
commit dbe83c0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/sidekiq/failures/middleware.rb b/lib/sidekiq/failures/middleware.rb
@@ -10,7 +10,7 @@ def call(worker, msg, queue)
         yield
       rescue Sidekiq::Shutdown
         raise
-      rescue => e
+      rescue Exception => e
         raise e if skip_failure?
 
         data = {

diff --git a/test/middleware_test.rb b/test/middleware_test.rb
@@ -13,7 +13,7 @@ module Failures
         Sidekiq.instance_eval { @failures_default_mode = nil }
       end
 
-      TestException = Class.new(StandardError)
+      TestException = Class.new(Exception)
       ShutdownException = Class.new(Sidekiq::Shutdown)
 
       class MockWorker