Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass a data.table as 'data' #105

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

CyrilLagger
Copy link
Contributor

@CyrilLagger CyrilLagger commented Mar 15, 2021

Fixes #102.

I also modified test-data.R accordingly.

@codecov-io
Copy link

codecov-io commented Mar 15, 2021

Codecov Report

Merging #105 (123757c) into master (0608c1e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #105   +/-   ##
=======================================
  Coverage   95.55%   95.55%           
=======================================
  Files           4        4           
  Lines        1416     1416           
=======================================
  Hits         1353     1353           
  Misses         63       63           
Impacted Files Coverage Δ
R/data.R 96.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0608c1e...123757c. Read the comment docs.

Copy link
Owner

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@krassowski krassowski merged commit 0800142 into krassowski:master Mar 16, 2021
@krassowski
Copy link
Owner

Thank you for your contribution!

@CyrilLagger
Copy link
Contributor Author

No problem! Glad I could help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error "'x' must be an array of at least two dimensions" when passing a data.table instead of data.frame
3 participants