Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrections #9

Merged
merged 5 commits into from
Nov 28, 2017
Merged

corrections #9

merged 5 commits into from
Nov 28, 2017

Conversation

danklotz
Copy link
Contributor

Some minor corrections:

  • Always we (instead of sometimes you)
  • on -> one
  • minor spelling mistakes

Changed some formulations. I think they are better readable that way, but not 100% sure.

@kratzert
Copy link
Owner

kratzert commented Nov 25, 2017

Can't open your notebook to view the changes. Get

NotJSONError('Notebook does not appear to be JSON: \'{\\n "cells": [\\n  {\\n   "cell_type": "m...',)

Are you sure you made your edits in the jupyter notebook or in jupyter lab? Or did you made the changes directly to the file with some editor and might have broken the format?

Also please make sure to rebase your fork to the current master branch. Saw your fork is based to a very old commit.

@danklotz
Copy link
Contributor Author

Mh.. It seems to be due to the git-markings. So it should actually be fine already. Strangely enough it does not seem to be...

@kratzert
Copy link
Owner

Seems good now and can be opened now on my local machine.

@kratzert kratzert merged commit 267926f into kratzert:master Nov 28, 2017
kratzert added a commit that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants