Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vue-jsx #1546

Merged
merged 6 commits into from
Dec 30, 2023
Merged

feat: add vue-jsx #1546

merged 6 commits into from
Dec 30, 2023

Conversation

manyuemeiquqi
Copy link
Contributor

I add vue-jsx framwork

@krausest krausest merged commit 07c534e into krausest:master Dec 30, 2023
@krausest
Copy link
Owner

Thanks. Your implementation had two issues:

  1. Selecting rows didn't work. Please review my fix (2a81628), I'm not sure if that is the reason for slow performance with select rows.
  2. The container class was missing.
    I updated to vue 3.4.0 since there's an open PR to push vue to 3.4.0. So I though we could jump to that version.

Here's a screenshot (left new keyed versions + vue as a reference, right old versions):
Screenshot 2023-12-31 at 10 30 45 AM

Even without select rows it doesn't look like using jsx for vue is performance wise a good idea.

@manyuemeiquqi
Copy link
Contributor Author

manyuemeiquqi commented Dec 31, 2023

Thanks, this is pretty much the same as my local test .
I know JSX + Vue performance is not good, I just want to approve JSX performance is not particularly bad, and there seems has room for optimization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants