[WIP] Improve Dioxus #1646
Draft
[WIP] Improve Dioxus #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got pretty far in a rewrite here to stick to the Hooks rules. I tried aligning this implementation closer to how Leptos impl. looks. I do get some issues with generational references though when I'm trying to loop over the rows in the template, but otherwise things looked promising.
Related to
Correct me if i'm wrong, but with hooks rules etc., this feels a lot more like react useState, than actuals signals. I think read/write separation would have helped me in this implementation, because it's harder to carry a mutable reference around in the rsx!, e.g. when looping over the rows, when i technically only have to read the signal to do that.